[PATCH] D97201: [flang] Detect circularly defined interfaces of procedures

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld updated this revision to Diff 326707.
PeteSteinfeld added a comment.

I changed the solution to the problem with SymbolSet having an inconsistent "<"
operator by making it unordered.

I investigated changing the definition of the "<" operator, but it's used in
many different places as the key for map types and to sort symbols.

Peter has noted that the current implementation of the "<" operator for Symbol
relies on the fact that its arguments are in the same cooked character stream.
This assumption is violated when at least one of the symbols being compared
comes from a .mod file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97201/new/

https://reviews.llvm.org/D97201

Files:
  flang/include/flang/Semantics/symbol.h
  flang/lib/Semantics/resolve-names.cpp
  flang/test/Semantics/resolve102.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97201.326707.patch
Type: text/x-patch
Size: 8238 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210226/4ad1a56d/attachment.bin>