[PATCH] D97557: [PDB] Fix unsigned integer overflow

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 26 08:28:17 PST 2021


thakis added a comment.

In D97557#2590412 <https://reviews.llvm.org/D97557#2590412>, @hans wrote:

> (I've written and been bit by this bug at least one time that I remember. I wonder if clang could have warning tailored to it..)

(I guess you'd pattern-match for `if (a_with_some_int_type != b_with_some_int_type) return a_with_some_int_type - b_with_some_int_type;` and warn on that and propose a diff like in this patch as fixit? could work!)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97557/new/

https://reviews.llvm.org/D97557



More information about the llvm-commits mailing list