[PATCH] D97525: [llvm][utils] Support dereferencing llvm::Optional lldb formatter

Dave Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 26 08:13:43 PST 2021


kastiglione added inline comments.


================
Comment at: llvm/utils/lldbDataFormatters.py:135
+        if name == '$$dereference$$':
+            return self.valobj.num_children + 1
+        return self.valobj.GetIndexOfChildWithName(name)
----------------
oops this was an innocuous off by one (it still worked), I removed the `+1` in a01a406bba8ac624a876f8d5720e1d4949a5b0fa


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97525/new/

https://reviews.llvm.org/D97525



More information about the llvm-commits mailing list