[PATCH] D97525: [llvm][utils] Support dereferencing llvm::Optional lldb formatter

[Raphael Isemann via Phabricator via llvm-commits]

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

LGTM, but please land the renames for `dict` in their own NFC commit (no need to open a review for that obviously)



================
Comment at: llvm/utils/lldbDataFormatters.py:141
+            return self.valobj.GetChildAtIndex(index)
+        return GetOptionalValue(self.valobj) or lldb.SBValue()
 
----------------
kastiglione wrote:
> @teemperor this is why the `import lldb` is needed
Thanks, missed that use


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97525/new/

https://reviews.llvm.org/D97525