[PATCH] D96653: [FileCheck] Add neighboring annotations for -dump-input-filter=error

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 26 06:44:46 PST 2021


jdenny added a comment.

In D96653#2589630 <https://reviews.llvm.org/D96653#2589630>, @jhenderson wrote:

>> What do you think? Looking at the implementation, I think search ranges would be easy to capture for errors.
>
> Sorry for not spotting this question before. Your proposals seem okay to me,

Thanks for considering it.

> but I'm not sure I personally have any particular useful opinions on the topic, as I tend not to use the --dump-input option for various reasons, which are outside the scope of this work.

I agree that should be a separate discussion, but I'd be interested to have it.  Maybe it would lead to a better solution.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96653/new/

https://reviews.llvm.org/D96653



More information about the llvm-commits mailing list