[PATCH] D97547: [AMDGPU] Better codegen for i64 bitreverse

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 26 05:53:56 PST 2021


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:5746
+    case AMDGPU::S_BREV_B64:
+      splitScalar64BitUnaryOp(Worklist, Inst, AMDGPU::S_BREV_B32, true);
+      Inst.eraseFromParent();
----------------
arsenm wrote:
> I don't see how you can just replace this with the two reversed halves. That would give you abcd -> badc instead of dcba
That's why I set Swap = true, to also swap the two halves.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97547/new/

https://reviews.llvm.org/D97547



More information about the llvm-commits mailing list