[PATCH] D88287: [NARY-REASSOCIATE] Support reassociation of min/max

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Current: https://alive2.llvm.org/ce/z/x8NBH8

In D88287#2589841 <https://reviews.llvm.org/D88287#2589841>, @ebrevnov wrote:

> I think the solution is to use >= instead of > when we do min/max reassociation. In other words, originally we had 'any' > MAX_INT which is known to be false. If we want semantically equal but reassociated expression we should invert the comparison logic. In other words we should check MAX_INT >= 'any' which is known to be true and MAX_INT will be selected.

No. <https://alive2.llvm.org/ce/z/GTu4Ek>

Like i have already said, the fix is https://alive2.llvm.org/ce/z/RkBWxC.
Let me just fix this then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88287/new/

https://reviews.llvm.org/D88287