[PATCH] D95511: [llvm-readelf] Support dumping the BB address map section with --bb-addr-map.

Rahman Lavaee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 26 01:43:42 PST 2021


rahmanl added inline comments.


================
Comment at: llvm/unittests/Object/ELFObjectFileTest.cpp:533
+  OverInt32LimitYamlStrings[0] += R"(
+          - AddressOffset: 0xFFFFFFFF3
+            Size:          0x4
----------------
jhenderson wrote:
> It might make sense to do proper edge-case testing here, with values of `0xffffffff` and `0x100000000`.
Good idea. Done here and below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95511/new/

https://reviews.llvm.org/D95511



More information about the llvm-commits mailing list