[PATCH] D97501: [ARM] support symbolic expressions as branch target

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:1079
     }
-    return false;
+    // Delay the checks of symbolic values until they are resolved
+    return true;
----------------
I cant help but wonder whether we should leave `isSignedOffset` as is, and modify decisions to check vs delay up into the relevant call site?  All of these `is<Something>` checks for operands have nice symmetry, so it's curious to disturb it just for `isSignedOffset`.


================
Comment at: llvm/test/MC/ARM/thumb2-branch-ranges.s:100-101
+// branch to thumb function resolved at assembly time
+// CHECK-NOT: error
+// CHECK: [[@LINE+1]]:{{[0-9]}}: error: Relocation out of range
+        b.w start8 - start7 + 0x1000000
----------------
This checks that `error` is not printed in the output, but then checks that `error: ...` is? Or am I misunderstanding that? (I guess I don't understand the point of the `CHECK-NOT`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97501/new/

https://reviews.llvm.org/D97501