[PATCH] D97520: [basicaa] Rewrite isGEPBaseAtNegativeOffset in terms of index difference [NFC]

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 25 18:27:24 PST 2021


reames created this revision.
reames added reviewers: nikic, fhahn.
Herald added subscribers: dantrushin, arphaman, hiraditya, mcrosier.
Herald added a reviewer: bollu.
reames requested review of this revision.
Herald added a project: LLVM.

This should be purely NFC, it just fits more obviously in the flow of the code now that we've standardized on the index different approach.

One subtle point - the placement of this above the BaseAlias check is important in the original code as this can return NoAlias even when we can't find a relation between the bases otherwise.

Also added some enhancement TODOs noticed while understanding the existing code.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97520

Files:
  llvm/lib/Analysis/BasicAliasAnalysis.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97520.326575.patch
Type: text/x-patch
Size: 5772 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210226/b10fb680/attachment.bin>


More information about the llvm-commits mailing list