[PATCH] D97481: [CSSPGO] Unblocking optimizations by dangling pseudo probes.
Wei Mi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 25 18:22:04 PST 2021
wmi added a comment.
A general question, do we care about where we should put dangling probe? Currently dangling probes are scattered in some predecessor/successor blocks they don't belong to. Looks like they can be anywhere. Wondering whether it is better to collect all of them to some place (entry block?). I am not sure about it either. Just want to know what you think.
================
Comment at: llvm/include/llvm/CodeGen/MachineBasicBlock.h:674
/// or end().
- iterator getFirstNonDebugInstr();
- const_iterator getFirstNonDebugInstr() const {
- return const_cast<MachineBasicBlock *>(this)->getFirstNonDebugInstr();
+ iterator getFirstNonDebugInstr(bool SkipPseudoOp = false);
+ const_iterator getFirstNonDebugInstr(bool SkipPseudoOp = false) const {
----------------
In which case SkipPseudoOp needs to be true and which case to be false?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97481/new/
https://reviews.llvm.org/D97481
More information about the llvm-commits
mailing list