[PATCH] D97338: [Orc] Use extensible RTTI for the orc::ObjectLayer class hierarchy

[Lang Hames via Phabricator via llvm-commits]

lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

In D97338#2588010 <https://reviews.llvm.org/D97338#2588010>, @dblaikie wrote:

> This alternative, at least, looks like it uses an extra non-static member variable, compared to the original use of a static member. That's a fairly significant tradeoff/cost to add in terms of extra size to every derived object.

Yeah -- We considered designs using a non-static type member at the time, but decided against them for this reason. I haven't come up with a good solution that avoids CRTP and static members yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97338/new/

https://reviews.llvm.org/D97338