[PATCH] D97501: [ARM] support symbolic expressions as branch target

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 25 17:01:03 PST 2021


MaskRay added inline comments.


================
Comment at: llvm/test/MC/ARM/thumb2-b.w-target.s:10
+// llvm-objdump produced the following
+// CHECK:	0: ff f3 fc 97  	b.w	#16777208 <$t.0+0xfffffc>
+// CHECK-NEXT:	4: 00 f0 01 b8  	b.w	#2 <$t.0+0xa>
----------------
nickdesaulniers wrote:
> nickdesaulniers wrote:
> > can you add whitespace after the `:` so this is slightly more readable?
> ie. to align the columns.
Delete encodings. Separations of concerns: they are tested by encoding/decoding tests.

You can add a label, then you can use `CHECK-LABEL: <foo>:` and `CHECK-NEXT:`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97501/new/

https://reviews.llvm.org/D97501



More information about the llvm-commits mailing list