[PATCH] D97501: [ARM] support symbolic expressions as branch target

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added a comment.

With this patch applied, I can _build_ an armv7 THUMB2 linux kernel w/ Clang's integrated assembler, which I haven't been able to previously.

This looks like the last blocker to ship Clang's integrated assembler for Linux kernel's in Android (not the last bug, but the last one I'd consider a hard blocker).



================
Comment at: llvm/test/MC/ARM/thumb2-b.w-target.s:6-7
+// arm-linux-gnueabihf-objdump produced
+//	0:	f3ff 97fc 	b.w	fffffc <.text+0xfffffc>
+//	4:	f000 b801 	b.w	a <.text+0xa>
+
----------------
Does anyone know why GNU objdump and llvm-objdump differ in the byte ordering? Looks like a pre-existing bug, but man does it look strange.


================
Comment at: llvm/test/MC/ARM/thumb2-b.w-target.s:10-11
+// llvm-objdump produced the following
+// CHECK:	0: ff f3 fc 97  	b.w	#16777208 <$t.0+0xfffffc>
+// CHECK-NEXT:	4: 00 f0 01 b8  	b.w	#2 <$t.0+0xa>
+1:
----------------
can you add whitespace after the `:` so this is slightly more readable?


================
Comment at: llvm/test/MC/ARM/thumb2-b.w-target.s:17-20
+
+
+
+
----------------
delete newlines


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97501/new/

https://reviews.llvm.org/D97501