[PATCH] D97482: [CSSPGO] Deduplicating dangling pseudo probes.

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/lib/IR/PseudoProbe.cpp:139
+/// multiple copies of them.
+bool removeRedundantPseudoProbes(BasicBlock *Block) {
+
----------------
wmi wrote:
> If the interface can be changed to collectRedundantPseudoProbes(BasicBlock *Block, SmallVectorImpl<PseudoProbeInst *> &ToBeRemoved), it can be reused by the code above to remove redundent probes for the function.
> 
> 
Thanks for the suggestion. The code above actually handles MIR pseudo probe intrinsics while the code here handles IR intrinsics. I was thinking about sharing them but I feel templated code maybe needed and not sure about the worth of that complexity. What do you think? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97482/new/

https://reviews.llvm.org/D97482