[PATCH] D88392: [M68k] (Patch 6/8) IR Tests

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 25 15:45:34 PST 2021


myhsu added inline comments.


================
Comment at: llvm/test/CodeGen/M68k/ASM/CodeModel/medium-pie-global-access.ll:3
+; RUN: llc < %s -O2 -mtriple=m68k-linux-gnu -verify-machineinstrs \
+; RUN:              -code-model=medium -relocation-model=pic        \
+; RUN: | FileCheck %s
----------------
jrtc27 wrote:
> These backslashes don't line up; either line them up everywhere or only leave one space before the backslash. I count 71 cases of multiple spaces before a backslash; some of those might be lined up already but they should be audited. I'd be inclined to just do a mass `sed -i '/^[;#]/s/   *\\/ \\/` (and verify the result...) rather than going through and lining everything up (other backends don't bother).
thanks for the command!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88392/new/

https://reviews.llvm.org/D88392



More information about the llvm-commits mailing list