[PATCH] D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 25 15:14:26 PST 2021


dblaikie added a comment.

In D97311#2588877 <https://reviews.llvm.org/D97311#2588877>, @aprantl wrote:

>> Guess it gets a bit complicated if it has to support non-local constants too.
>
> We can already represent optimized out global variables with constant values as `!DIGlobalVariableExpression(!DIGlobalVariable(...), !DIExpression(DW_OP_constu, ...))`.
> We would have to also add a bit to DIGlobalVariable, but other than that this seems perfectly feasible?

Yeah, I'm certainly OK with that, if it sounds good to you to do that in those two places.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97311/new/

https://reviews.llvm.org/D97311



More information about the llvm-commits mailing list