[PATCH] D88390: [M68k] (Patch 4/8) MC layer and object file support

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu marked 8 inline comments as done.
myhsu added inline comments.


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kELFObjectWriter.cpp:63
+
+// FIXME Handle reloc differences between pre-M68020 models and successors
+unsigned M68kELFObjectWriter::getRelocType(MCContext &Ctx,
----------------
jrtc27 wrote:
> jrtc27 wrote:
> > This is odd; processors shouldn't care about fixups. But regardless of the actual problem, more info would be helpful as this isn't particularly useful for anyone who doesn't already know the problem.
> Please clarify this comment or delete if it it's wrong
I confirm this comment is outdated


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kMCCodeEmitter.cpp:378-381
+    // Since M68k is Big Endian we need to rotate each instruction word
+    while (Offset / 16) {
+      OS.write((char)((Buffer >> 8) & 0xFF));
+      OS.write((char)((Buffer >> 0) & 0xFF));
----------------
jrtc27 wrote:
> should work as a nicer way to write that (using llvm/Support/EndianStream.h)
good to know, thanks


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88390/new/

https://reviews.llvm.org/D88390