[PATCH] D97403: updated character tests to gtest

[Asher Mancinelli via Phabricator via llvm-commits]

ashermancinelli added inline comments.


================
Comment at: flang/unittests/RuntimeGTest/CharacterTest.cpp:24-26
+    if (x[limit]) {
+      EXPECT_TRUE(false) << "x[" << limit << "]='" << x[limit] << "'\n";
+      x[limit] = '\0';
----------------
awarzynski wrote:
> Perhaps:
> ```
> EXPECT_NE(x[limit], `\0`)  << "x[" << limit << "]='" << x[limit] << "'\n";
> ```
> IMHO this would be clearer.
I agree, but this should be
```
EXPECT_EQ(x[limit], '\0') << "x[" << limit << "]='" << x[limit] << "'";
```
correct?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97403/new/

https://reviews.llvm.org/D97403