[PATCH] D97478: [X86] Remove custom lowering of vXi1 ADD/SUB now that they are canonicalized to XOR in getNode.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 25 10:31:48 PST 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:1475
       setOperationAction(ISD::USUBSAT,          VT, Custom);
       setOperationAction(ISD::SSUBSAT,          VT, Custom);
       setOperationAction(ISD::VSELECT,          VT,  Expand);
----------------
RKSimon wrote:
> I've moved the ADD/SUB SAT folds at rG9490b9f14b899ff07f3cfab7ad64e5fed8f48746 - are you OK with me removing these as well?
Yes. What about MUL?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97478/new/

https://reviews.llvm.org/D97478



More information about the llvm-commits mailing list