[PATCH] D97338: [Orc] Add LLVM-style RTTI for orc::ObjectLayer

Stefan Gränitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 25 09:18:24 PST 2021


sgraenitz added a comment.

Thanks for having a look. Yes, extensibility is a good point. I switched it to the ExtensibleRTTI implementation and it works well. It's the first use-case in LLVM so far:
https://llvm.org/docs/HowToSetUpLLVMStyleRTTI.html#rtti-for-open-class-hierarchies

I have to admit I am not very happy with the CRTP approach in there. I hacked forward a bit to look for an alternative and it is possible: https://reviews.llvm.org/differential/diff/326409/#change-EaiHppkLE6Ki, but it's not in a state where it could land any time soon and I don't have the capacity to get it ready for review now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97338/new/

https://reviews.llvm.org/D97338



More information about the llvm-commits mailing list