[PATCH] D97484: Don't use $ as suffix for symbol names in ThinLTOBitcodeWriter and other places

[Hans Wennborg via Phabricator via llvm-commits]

hans created this revision.
hans added reviewers: rnk, thakis, pcc, tejohnson.
Herald added subscribers: dexonsmith, arphaman, steven_wu, hiraditya, inglorion.
hans requested review of this revision.
Herald added a project: LLVM.

Using $ breaks demangling of the symbols. For example,

  $ c++filt _Z3foov$123
  _Z3foov23

This causes problems for developers who would like to see nice stack traces etc. but also for automatic crash tracking systems which try to organize crashes based on the stack traces.

Instead, use the period as suffix separator, since Itanium demanglers normally ignore such suffixes. This is already done in some places; create a utility function to do it, and try to use that everywhere.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97484

Files:
  llvm/include/llvm/IR/Module.h
  llvm/include/llvm/IR/ModuleSummaryIndex.h
  llvm/lib/IR/Module.cpp
  llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp
  llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp
  llvm/test/ThinLTO/X86/devirt2.ll
  llvm/test/Transforms/ThinLTOBitcodeWriter/split-internal1.ll
  llvm/test/Transforms/ThinLTOBitcodeWriter/split-internal2.ll
  llvm/test/Transforms/ThinLTOBitcodeWriter/split-vfunc-internal.ll
  llvm/test/Transforms/WholeProgramDevirt/export-single-impl.ll
  llvm/tools/llvm-lto2/llvm-lto2.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97484.326420.patch
Type: text/x-patch
Size: 10228 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210225/bc5ffe82/attachment.bin>