[PATCH] D97432: [SanitizerCoverage] Don't use llvm.used if comdat

[Matt Morehouse via Phabricator via llvm-commits]

morehouse added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:688
+    GlobalsToAppendToUsed.push_back(Array);
+    GlobalsToAppendToCompilerUsed.push_back(Array);
+  }
----------------
Don't we still need compiler used?  https://llvm.org/docs/LangRef.html#associated-metadata

Also even without this change they are only marked "used" on Mac currently, IIRC due to GC issues with their linker.


================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:690
+  }
 
   return Array;
----------------
What happened to the associated metadata that's added here at ToT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97432/new/

https://reviews.llvm.org/D97432