[PATCH] D97393: [OpenMP IRBuilder] Add support for OpenMP do schedule dynamic

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:1170
+// runtime. Always interpret integers as unsigned similarly to
+// CanonicalLoopInfo.
+static FunctionCallee
----------------
I think we sue doxygen comments `///` for static functions as well.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:1288
+    It = Inst->eraseFromParent();
+  }
+
----------------
I don't know what this does but it looks brittle. We should have handles for all values, e.g., "the old condition", which we can remove is necessary by following the handle and the operands (with a single use).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97393/new/

https://reviews.llvm.org/D97393