[PATCH] D97218: [AMDGPU] Set threshold for regbanks reassign pass

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/GCNRegBankReassign.cpp:668
 
   for (MCRegister Reg : RC->getRegisters()) {
     // Check occupancy limit.
----------------
arsenm wrote:
> rampitec wrote:
> > arsenm wrote:
> > > Can you redo this search process in terms of regunits instead? 
> > I will need to supply a physreg for VRM at the end. Plus all these isAllocatable() et all checks are not for reg units.
> VRM should be using regunits internally. It does have  LiveRegMatrix::checkRegUnitInterference. Overall we need to rewrite everything considering registers to operate on regunits instead (including reframing reserved registers in terms of reserved regunits)
I guess checkRegUnitInterference is part of the implementation, but that just means you're repeating that multiple times by scanning over all of the registers in tuple classes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97218/new/

https://reviews.llvm.org/D97218