[PATCH] D97069: [clang] BoolMOption helper in Options.td

[Jan Svoboda via Phabricator via llvm-commits]

jansvoboda11 added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:431
+// specified by the OptGroup argument, otherwise Group<m_Group>.
+multiclass BoolMOption<string flag_base,
+                       string HelpStringEnabled, string HelpStringDisabled,
----------------
rampitec wrote:
> jansvoboda11 wrote:
> > Can you please rename this to `BoolMFlag` and model it after `BoolFFlag`?
> > 
> > The `Bool?Option` multiclasses were created for fine-grained control of cc1 flag marshalling, which your implementation doesn't do/need. https://clang.llvm.org/docs/InternalsManual.html#option-marshalling-infrastructure
> It does not seem that BoolFFlag exists?
Ah, sorry, I meant `OptInFFlag` and `OptOutFFlag`.

You probably won't need the `KeyPathAndMacro` and `enablers` parameters, as you're not targeting cc1.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97069/new/

https://reviews.llvm.org/D97069