[PATCH] D96409: [debug-info] refactor emitDwarfUnitLength

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 22 02:20:30 PST 2021


ikudrin accepted this revision.
ikudrin added a comment.

LGTM, thanks!



================
Comment at: llvm/lib/MC/MCStreamer.cpp:1013-1014
   AddComment(Comment);
+  MCSymbol *Lo = Context.createTempSymbol(Prefix + "start");
+  MCSymbol *Hi = Context.createTempSymbol(Prefix + "end");
+
----------------
Maybe use `"_start"` and `"_end"` here and avoid passing the trailing `'_'` in the argument?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96409/new/

https://reviews.llvm.org/D96409



More information about the llvm-commits mailing list