[PATCH] D97459: [CodeGen] Fix issues with subvector intrinsic index types

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/ISDOpcodes.h:1049
 
-  /// UBSANTRAP - Trap with an immediate describing the kind of sanitizer failure.
+  /// UBSANTRAP - Trap with an immediate describing the kind of sanitizer
+  /// failure.
----------------
frasercrmck wrote:
> sdesmalen wrote:
> > nit: unrelated change.
> True. It's something `arcanist` prompted me about when creating the patch. Should probably just be pre-committed?
Either that, or you can just ignore it.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:8018
 /// equivalent value in the V128 register class.
 static SDValue WidenVector(SDValue V64Reg, SelectionDAG &DAG) {
   EVT VT = V64Reg.getValueType();
----------------
frasercrmck wrote:
> I've just noticed that you may now be able to use `SelectionDAG::WidenVector` here? That's definitely outside the scope of this patch, though.
Yes, you're probably right, good catch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97459/new/

https://reviews.llvm.org/D97459