[PATCH] D97155: [MSSA] Extending IsGuaranteedLoopInvariant to support an instruction defined in the entry block

Thu Feb 25 04:20:41 PST 2021

fvrmatteo added a comment.

In D97155#2579921 <https://reviews.llvm.org/D97155#2579921>, @fhahn wrote:

>> I didn't provide a test yet, because it's not clear to me how to create one that is showing the improvement in the MemorySSA case.
>
> Could you add a variant of the test added in a0017c2bc258690146f18491317144e487ddb101 <https://reviews.llvm.org/rGa0017c2bc258690146f18491317144e487ddb101> ?

I tried, but even though I see the new code being triggered and successfully returning **true** when expected to do so, I can't seem to notice any difference when printing the MemorySSA information (with `-aa-pipeline=basic-aa -passes='print<memoryssa>,verify<memoryssa>'`). So I'm still clueless on what should be the expected testable behaviour.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97155/new/

https://reviews.llvm.org/D97155