[PATCH] D97459: [CodeGen] Fix issues with subvector intrinsic index types

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

Hi @frasercrmck thanks for fixing this, this seems like an oversight when adding the intrinsic.



================
Comment at: llvm/include/llvm/CodeGen/ISDOpcodes.h:1049
 
-  /// UBSANTRAP - Trap with an immediate describing the kind of sanitizer failure.
+  /// UBSANTRAP - Trap with an immediate describing the kind of sanitizer
+  /// failure.
----------------
nit: unrelated change.


================
Comment at: llvm/test/CodeGen/AArch64/vecreduce-and-legalization.ll:104
+; CHECK-NEXT:    mov v1.b[11], w8
+; CHECK-NEXT:    mov v1.b[13], w8
+; CHECK-NEXT:    ext v1.16b, v1.16b, v1.16b, #8
----------------
Probably not something that's caused by your patch, but I would have expected that elements `v1.b[12], v1.b[14] and v1.b[15]` to also be set to `-1`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97459/new/

https://reviews.llvm.org/D97459