[PATCH] D97382: NFC: Migrate PartialInlining to work on InstructionCost
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 25 03:05:58 PST 2021
sdesmalen added inline comments.
================
Comment at: llvm/include/llvm/Support/InstructionCost.h:117
+ template <typename T,
+ typename = std::enable_if_t<std::is_floating_point<T>::value>>
----------------
ctetreau wrote:
> why is this necessary?
I wasn't really sure what type to choose for RHS (`float` or `double`), so I thought I'd just template the type for any floating point type.
The operator is needed for a multiplication in PartialInlining with the options `MinRegionSizeRatio` and `ColdBranchRatio` which in this case are both of type `float`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97382/new/
https://reviews.llvm.org/D97382
More information about the llvm-commits
mailing list