[PATCH] D97268: [X86] Use correct padding when in 16-bit mode

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 19:29:50 PST 2021


MaskRay added inline comments.


================
Comment at: llvm/test/MC/X86/code16gcc-align.s:7
+# CHECK-LABEL: <test>:
+# CHECK:           22: 66 89 c7                     	movl	%eax, %edi
+# CHECK-NEXT:      25: 66 31 db                     	xorl	%ebx, %ebx
----------------
Need a test for the 2-byte nop.


================
Comment at: llvm/test/MC/X86/code16gcc-align.s:25
+	movzbl	(%esi,%ebx), %ecx
+	calll	called
+	retl
----------------
All the following instructions and directives can be deleted.

You can drop .LBB0_2 too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97268/new/

https://reviews.llvm.org/D97268



More information about the llvm-commits mailing list