[PATCH] D97430: [SanitizerCoverage] Drop !associated on metadata sections
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 24 18:04:29 PST 2021
vitalybuka added a comment.
Thanks for the quick fix!
================
Comment at: llvm/lib/Transforms/Instrumentation/Instrumentation.cpp:94-95
// Make a new comdat for the function. Use the "no duplicates" selection kind
// for non-weak symbols if the object file format supports it.
Comdat *C = M->getOrInsertComdat(Name);
----------------
this comment does not match condition now
================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:686-688
GlobalsToAppendToCompilerUsed.push_back(Array);
- MDNode *MD = MDNode::get(F.getContext(), ValueAsMetadata::get(&F));
- Array->addMetadata(LLVMContext::MD_associated, *MD);
----------------
Why removing these lines does not change COFF behaviour ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97430/new/
https://reviews.llvm.org/D97430
More information about the llvm-commits
mailing list