[PATCH] D97412: [Remarks] Provide more information about auto-init stores

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg marked an inline comment as done.
thegameg added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/AutoInitRemark.cpp:29
+  if (Volatile)
+    R << " Volatile: " << NV("StoreVolatile", true) << ".";
+  if (Atomic)
----------------
thegameg wrote:
> paquette wrote:
> > I think it may be worth handling the false case here as well. People may want to search for non-volatile and non-atomic stores in the remarks.
> In my experience volatile/atomic auto-init stores are **very** uncommon. While I agree that it's convenient for scripts and such to have it anyway, I wonder if it doesn't pollute the remark message too much.
> 
> Maybe I can put it under `setExtraArgs`...
Yep, that worked, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97412/new/

https://reviews.llvm.org/D97412