[PATCH] D97310: [dfsan] Conservative solution to atomic load/store

[Matt Morehouse via Phabricator via llvm-commits]

morehouse accepted this revision.
morehouse added inline comments.
This revision is now accepted and ready to land.


================
Comment at: compiler-rt/test/dfsan/atomic.cpp:39
+  return 0;
+}
----------------
stephan.yichao.zhao wrote:
> morehouse wrote:
> > Should we also test builtin atomics?  https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html
> Yes. 
> 
> DFSan needs some extension to work with Builtins. MSan uses a function pass TargetLibraryInfoWrapperPass to identify builtin calls, while DFSan is a module pass.
> And DFSan's ABI does not work with builtins because builtins do not have C libcalls.
> 
> Our current internal use cases do not support Builtins. But we need to support them in the next step.
Please add a TODO for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97310/new/

https://reviews.llvm.org/D97310