[PATCH] D97239: [profile] Fix buffer overrun when parsing %c in filename string

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 14:39:55 PST 2021


vsk updated this revision to Diff 326209.
vsk added a comment.

Address review feedback. I opted to add the `checkBounds` helper, as this seemed like the least invasive option. The convention in the rest of this library appears to be to not use stdbool.h, so I decided not to pull it in here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97239/new/

https://reviews.llvm.org/D97239

Files:
  compiler-rt/lib/profile/InstrProfilingFile.c
  compiler-rt/test/profile/ContinuousSyncMode/get-filename.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97239.326209.patch
Type: text/x-patch
Size: 3450 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210224/be9ed642/attachment.bin>


More information about the llvm-commits mailing list