[llvm] 80f329b - [Profile] Include a few asserts in coverage mapping test

Petr Hosek via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 13:43:04 PST 2021


Author: Petr Hosek
Date: 2021-02-24T13:42:45-08:00
New Revision: 80f329bcd0281c11062879025761d0657167fe8b

URL: https://github.com/llvm/llvm-project/commit/80f329bcd0281c11062879025761d0657167fe8b
DIFF: https://github.com/llvm/llvm-project/commit/80f329bcd0281c11062879025761d0657167fe8b.diff

LOG: [Profile] Include a few asserts in coverage mapping test

These should catch any accidental use of the compilation directory.

Differential Revision: https://reviews.llvm.org/D97402

Added: 
    

Modified: 
    llvm/unittests/ProfileData/CoverageMappingTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/ProfileData/CoverageMappingTest.cpp b/llvm/unittests/ProfileData/CoverageMappingTest.cpp
index d1bb87ae966a..3f9a00b89954 100644
--- a/llvm/unittests/ProfileData/CoverageMappingTest.cpp
+++ b/llvm/unittests/ProfileData/CoverageMappingTest.cpp
@@ -145,8 +145,10 @@ struct CoverageMappingTest : ::testing::TestWithParam<std::pair<bool, bool>> {
 
   unsigned getGlobalFileIndex(StringRef Name) {
     auto R = Files.find(Name);
-    if (R != Files.end())
+    if (R != Files.end()) {
+      assert(R->second > 0 && "got index of compilation dir");
       return R->second;
+    }
     unsigned Index = Files.size() + 1;
     Files.try_emplace(Name, Index);
     return Index;
@@ -161,8 +163,10 @@ struct CoverageMappingTest : ::testing::TestWithParam<std::pair<bool, bool>> {
     auto &CurrentFunctionFileMapping =
         InputFunctions.back().ReverseVirtualFileMapping;
     auto R = CurrentFunctionFileMapping.find(GlobalIndex);
-    if (R != CurrentFunctionFileMapping.end())
+    if (R != CurrentFunctionFileMapping.end()) {
+      assert(R->second > 0 && "got index of compilation dir");
       return R->second;
+    }
     unsigned IndexInFunction = CurrentFunctionFileMapping.size();
     CurrentFunctionFileMapping.insert(
         std::make_pair(GlobalIndex, IndexInFunction));


        


More information about the llvm-commits mailing list