[PATCH] D96837: Add !retain metadata to retain global values under linker garbage collection

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

In D96837#2585874 <https://reviews.llvm.org/D96837#2585874>, @MaskRay wrote:

> @rnk I posted https://lists.llvm.org/pipermail/llvm-dev/2021-February/148760.html . This patch implements approach 2. If we do approach 1 (has support from @compnerd and @dblaikie), we don't need this metadata. What do you think of the tradeoff?

Proposal 1 of just keeping llvm.used and changing the semantics of the source level attribute seems fine to me as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96837/new/

https://reviews.llvm.org/D96837