[PATCH] D97316: AMDGPU: Add even aligned VGPR/AGPR register classes

Wed Feb 24 12:31:38 PST 2021

arsenm added a comment.

In D97316#2583098 <https://reviews.llvm.org/D97316#2583098>, @rampitec wrote:

> In D97316#2583083 <https://reviews.llvm.org/D97316#2583083>, @arsenm wrote:
>
>> In D97316#2583047 <https://reviews.llvm.org/D97316#2583047>, @rampitec wrote:
>>
>>> If coalesce-vgpr-alignment.ll and hiloeo-odd-coalesce.ll pass then you are right.
>>
>> I have a separate patch for this. coalesce-vgpr-alignment.ll is better and saves a move. I don't see hiloeo-odd-coalesce.ll
>
> Ah, right! It was included into coalesce-vgpr-alignment.ll. So does coalesce-vgpr-alignment.ll pass with that code from shouldCoalesce() removed? If it does I have no objections (except a nit with llvm_unreachable and some reported failing tests from the robot).

Oh, I thought you already accepted this and submitted this as 78b6d73a93fc6085d2a2fc84bdce1bbde740cf16 <https://reviews.llvm.org/rG78b6d73a93fc6085d2a2fc84bdce1bbde740cf16>. The switch doesn't need unreachable because it's technically just over an integer, and there's no covered enum

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97316/new/

https://reviews.llvm.org/D97316