[PATCH] D97046: [lit] Add "late_tests" test suite config option

[Julian Lettner via Phabricator via llvm-commits]

yln added inline comments.


================
Comment at: llvm/utils/lit/lit/TestingConfig.py:130-133
         # List of tests to run early.
         self.early_tests = {}
+        # Regular expression for tests to run late.
+        self.late_tests = "^$"
----------------
jhenderson wrote:
> davezarzycki wrote:
> > jhenderson wrote:
> > > Why are late tests a regular expression, but early tests a list? The inconsistency seems confusing to me.
> > "late_tests" does not need to be regular expression. It was just expedient given my goals. The "late_tests" variable could be a list if directories if we treat tests therein as being "late".
> I think users will expect the two to be the same type. I don't mind which way around it is personally, and I think applying the rule (whether early or late) to all tests within a directory, when a directory is specified, would be a good idea.
I agree with James here that it should be the same mechanism and would prefer a non-regex solution.

Maybe "test path prefix" is a good solution?  Specify full path to name an individual test or a prefix, to name a directory and have everything inside execute late/early.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97046/new/

https://reviews.llvm.org/D97046