[PATCH] D97027: [llvm-objdump][MachO] Add support for dumping function starts

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: llvm/tools/llvm-objdump/MachODump.cpp:1141
+  for (uint64_t S : FunctionStarts) {
+    uint64_t Addr = BaseSegmentAddress + S;
+    if (O->is64Bit())
----------------
thakis wrote:
> Should this add the base segment address? I'd expect `--function-starts` to dump the contents of FUNCTION_STARTS unmodified.
the thing is that `dyldinfo -function_starts` also prints addresses (+ it makes the usage of this option a tiny bit more straightforward)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97027/new/

https://reviews.llvm.org/D97027