[PATCH] D97398: add print-changed mode that does not use colour

[Jamie Schmeiser via Phabricator via llvm-commits]

jamieschmeiser added a comment.

Sure, the auto-detection could be used as you suggest, but the control is still needed by the user.  Consider what happens when auto-detection says the system supports colour and the user captures the output to a file.  They then bring it up in an editor (say vim or emacs) which doesn't recognize the colour characters and show as ^[[31m- and ^[[31m+ (in emacs or vim).  By giving the user control over whether they are generated, they can include them if they are examining the results on a screen (or using more) or strip them out when they plan to capture and edit the results (for large changes).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97398/new/

https://reviews.llvm.org/D97398