[PATCH] D97201: [flang] Detect circularly defined interfaces of procedures

Pete Steinfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 11:39:22 PST 2021


PeteSteinfeld updated this revision to Diff 326163.
PeteSteinfeld added a comment.

Responding to Peter's and Tim's comments.  The "<" operator is used not only
for SymbolSet, but it's also used to sort the elements in a SymbolVector in
several places.  The simplest and least disruptive fix was to follow another
suggestion from Tim to record the initial value of a symbol's name and use that
initial value as the basis for the "<" operator.  This change makes the result
of the "<" operator immune to calls to "ReplaceName()".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97201/new/

https://reviews.llvm.org/D97201

Files:
  flang/include/flang/Semantics/symbol.h
  flang/lib/Semantics/resolve-names.cpp
  flang/test/Semantics/resolve102.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97201.326163.patch
Type: text/x-patch
Size: 6226 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210224/d54a9917/attachment.bin>


More information about the llvm-commits mailing list