[PATCH] D97319: [RISCV] Support fixed vector extract element. Use VL=1 for scalable vector extract element.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 10:10:07 PST 2021


craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/extractelt-fp-rv32.ll:21
 ; CHECK-NEXT:    vslidedown.vi v25, v8, 2
+; CHECK-NEXT:    vsetvli zero, zero, e16,mf4,ta,mu
 ; CHECK-NEXT:    vfmv.f.s fa0, v25
----------------
frasercrmck wrote:
> I suppose this in theory could also be done with a VL set to 1. I doubt it'd be any more performant, but it'd save a `vsetvli` in this situation?
The way the vfmv.f.s pseudo is set up, there is no where to pass the VL. I think we can teach the RISCVCleanupVSETVLI pass to remove this though. I started on a patch for it yesterday. I'll try to finish it up today.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97319/new/

https://reviews.llvm.org/D97319



More information about the llvm-commits mailing list