[PATCH] D96351: [AIX] Enable the default AltiVec ABI on AIX

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 10:00:02 PST 2021


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:345-348
+      if (CSR_Altivec_SaveList[I] == 0)
+        break;
+
+      markSuperRegs(Reserved, CSR_Altivec_SaveList[I]);
----------------
If the code worked before the switch to the range-based for loop, then I suspect it doesn't now.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-csr-vector.ll:3
 ; RUN:     -mattr=+altivec -stop-after=prologepilog < %s | \
-; RUN:   FileCheck --check-prefix=MIR32 %s
+; RUN:   FileCheck --check-prefixes=MIR32,MIR32-DFL %s
 
----------------
There's no need to have the `DFL` prefix is it is always used with the corresponding "base" prefix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96351/new/

https://reviews.llvm.org/D96351



More information about the llvm-commits mailing list