[PATCH] D97398: add print-changed mode that does not use colour

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 09:51:16 PST 2021


aeubanks added a comment.

There's already color autodetection in clang somewhere, would that be useful as a default?



================
Comment at: llvm/test/Other/ChangePrinters/print-changed-diff.ll:65
 
+; Simple checks of -print-changed=cdiff
+;
----------------
I would have expected to see some diffs in the existing CHECK lines since they were previously emitting color directives, but now aren't

Am I missing something?


================
Comment at: llvm/test/Other/ChangePrinters/print-changed-diff.ll:106
+; others (including g) are filtered out.
+; RUN: opt -S -print-changed=cdiff-quiet -passes=instsimplify -filter-print-funcs=f  2>&1 -o /dev/null < %s | FileCheck %s --check-prefix=CHECK-CDIFF-QUIET-FUNC-FILTER
+;
----------------
`-disable-output`, although I guess it's a bit late to change all occurrences, at least in this change


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97398/new/

https://reviews.llvm.org/D97398



More information about the llvm-commits mailing list