[PATCH] D97236: [MC][ARM] add .w suffixes for BL (T1) and DBG

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 09:46:57 PST 2021


nickdesaulniers added inline comments.


================
Comment at: llvm/test/MC/ARM/basic-thumb2-instructions.s:659
+@ CHECK: it	ne                      @ encoding: [0x18,0xbf]
+@ CHECK: dbgne	#0                      @ encoding: [0xaf,0xf3,0xf0,0x80]
 
----------------
nickdesaulniers wrote:
> DavidSpickett wrote:
> > nit: indent the @ encoding
> I think phab is expanding tabs to a different number of spaces then 8.  With tabstop=8, the indentation is consistent throughout the file.
Yeah, if you click "show 20 lines" in phab, you can see what looks like existing cases of curious indentation.  It's just phab expanding tabs to a different number of spaces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97236/new/

https://reviews.llvm.org/D97236



More information about the llvm-commits mailing list