[PATCH] D95463: Avoid redundant or out-of-order debug value sinking in InstCombine

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 09:35:55 PST 2021


StephenTozer added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/debuginfo-sink.ll:74-75
+sink1:
+; CHECK-LABEL: sink1:
+; CHECK:       call void @llvm.dbg.value(metadata i32* %gep,
+; CHECK-SAME:  metadata !{{[0-9]+}}, metadata !DIExpression(DW_OP_plus_uconst, 5))
----------------
jmorse wrote:
> Doesn't this need a `CHECK-NOT dbg.value` in there, to verify that only one dbg.value is sunk?
I don't think so - this line should match either of the debug values, and the next lines are `CHECK-SAME` and `CHECK-NEXT`. As all the sunk debug values are in a single contiguous block, this should match iff there is only one debug value sunk.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95463/new/

https://reviews.llvm.org/D95463



More information about the llvm-commits mailing list