[PATCH] D96536: Make sure some types are indeed trivially_copyable per llvm::is_trivially_copyable

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 09:24:06 PST 2021


serge-sans-paille added a comment.



> It's better, I just still not completely get why that assert was necessary in the first place. I.e. what exact scenario is it trying to prevent? If we just want all `trivially_copyable` uses to be consistent across compilers, then that assert won't help (at the very least since std:: is not consistent across compiler/std versions).

Yeah, that was the original attempt: make sure that `llvm::is_trivially_copyable` was consistent with `std::is_trivially_copyable` when compiler implement it (at that time, some compiler were not supporting it all). As you know, experience proved that this was a naive approach :-/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96536/new/

https://reviews.llvm.org/D96536



More information about the llvm-commits mailing list