[PATCH] D97396: Use the default seed value for djb hash for StringMap

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 09:15:22 PST 2021


serge-sans-paille created this revision.
serge-sans-paille added a reviewer: JDevlieghere.
Herald added subscribers: dexonsmith, cmtice, hiraditya.
Herald added a reviewer: jhenderson.
serge-sans-paille requested review of this revision.
Herald added subscribers: llvm-commits, MaskRay.
Herald added a project: LLVM.

See original comment in 560ce2c70fb1fe8e4b9b5e39c54e494a50373ba8
Basically the default seed value results in less collision, but changes the
iteration order, which matters for a few test cases.

      

The performance gain was worth doing the test update.


https://reviews.llvm.org/D97396

Files:
  llvm/lib/Support/StringMap.cpp
  llvm/test/DebugInfo/Generic/accel-table-hash-collisions.ll
  llvm/test/DebugInfo/Generic/debug-names-hash-collisions.ll
  llvm/test/DebugInfo/X86/debug-pubtables-dwarf64.ll
  llvm/test/DebugInfo/X86/gnu-public-names.ll
  llvm/test/tools/llvm-dwarfdump/X86/section_sizes_archive.test
  llvm/test/tools/llvm-dwarfdump/X86/section_sizes_coff.test
  llvm/test/tools/llvm-dwarfdump/X86/section_sizes_elf.test
  llvm/test/tools/llvm-dwarfdump/X86/section_sizes_macho.test
  llvm/test/tools/llvm-dwarfdump/X86/statistics.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97396.326112.patch
Type: text/x-patch
Size: 11742 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210224/375090c1/attachment.bin>


More information about the llvm-commits mailing list